diff options
| author | Chao Yu | 2017-12-12 07:11:40 +0100 |
|---|---|---|
| committer | Jaegeuk Kim | 2018-01-03 04:27:30 +0100 |
| commit | 4635b46af2b3921829de09e4be1f6b71a62e4855 (patch) | |
| tree | fc75b374e32ec3a3f9df1a9c675fedd1a42c784d /fs/f2fs/acl.c | |
| parent | f2fs: no need return value in restore summary process (diff) | |
| download | kernel-qcow2-linux-4635b46af2b3921829de09e4be1f6b71a62e4855.tar.gz kernel-qcow2-linux-4635b46af2b3921829de09e4be1f6b71a62e4855.tar.xz kernel-qcow2-linux-4635b46af2b3921829de09e4be1f6b71a62e4855.zip | |
f2fs: fix potential hangtask in f2fs_trace_pid
As Jia-Ju Bai reported:
"According to fs/f2fs/trace.c, the kernel module may sleep under a spinlock.
The function call path is:
f2fs_trace_pid (acquire the spinlock)
f2fs_radix_tree_insert
cond_resched --> may sleep
I do not find a good way to fix it, so I only report.
This possible bug is found by my static analysis tool (DSAC) and my code
review."
Obviously, it's problemetic to schedule in critical region of spinlock,
which will cause uninterruptable sleep if there is no waker.
This patch changes to use mutex lock intead of spinlock to avoid this
condition.
Reported-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs/f2fs/acl.c')
0 files changed, 0 insertions, 0 deletions