diff options
| author | Chao Yu | 2014-12-18 10:37:21 +0100 |
|---|---|---|
| committer | Jaegeuk Kim | 2015-01-10 02:02:23 +0100 |
| commit | 5c27f4ee447b4ef1cd88d5313eeb838c56265571 (patch) | |
| tree | 4751969bf674317d57582deb6a59dda23f75f2a1 /fs/f2fs/node.c | |
| parent | f2fs: readahead contiguous current summary blocks in checkpoint (diff) | |
| download | kernel-qcow2-linux-5c27f4ee447b4ef1cd88d5313eeb838c56265571.tar.gz kernel-qcow2-linux-5c27f4ee447b4ef1cd88d5313eeb838c56265571.tar.xz kernel-qcow2-linux-5c27f4ee447b4ef1cd88d5313eeb838c56265571.zip | |
f2fs: merge two uchar variable in struct node_info to reduce memory cost
This patch moves one member of struct nat_entry: _flag_ to struct node_info,
so _version_ in struct node_info and _flag_ which are unsigned char type will
merge to one 32-bit space in register/memory. So the size of nat_entry will be
reduced from 28 bytes to 24 bytes (for 64-bit machine, reduce its size from 40
bytes to 32 bytes) and then slab memory using by f2fs will be reduced.
changes from v2:
o update description of memory usage gain for 64-bit machine suggested by
Changman Lee.
changes from v1:
o introduce inline copy_node_info() to copy valid data from node info suggested
by Jaegeuk Kim, it can avoid bug.
Reviewed-by: Changman Lee <cm224.lee@samsung.com>
Signed-off-by: Chao Yu <chao2.yu@samsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs/f2fs/node.c')
| -rw-r--r-- | fs/f2fs/node.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index cabecee88377..e565b9638971 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -269,7 +269,7 @@ static void set_node_addr(struct f2fs_sb_info *sbi, struct node_info *ni, e = __lookup_nat_cache(nm_i, ni->nid); if (!e) { e = grab_nat_entry(nm_i, ni->nid); - e->ni = *ni; + copy_node_info(&e->ni, ni); f2fs_bug_on(sbi, ni->blk_addr == NEW_ADDR); } else if (new_blkaddr == NEW_ADDR) { /* @@ -277,7 +277,7 @@ static void set_node_addr(struct f2fs_sb_info *sbi, struct node_info *ni, * previous nat entry can be remained in nat cache. * So, reinitialize it with new information. */ - e->ni = *ni; + copy_node_info(&e->ni, ni); f2fs_bug_on(sbi, ni->blk_addr != NULL_ADDR); } |