summaryrefslogtreecommitdiffstats
path: root/fs/namespace.c
diff options
context:
space:
mode:
authorTetsuo Handa2018-04-04 12:53:07 +0200
committerAl Viro2018-04-16 08:06:47 +0200
commit8e04944f0ea8b838399049bdcda920ab36ae3b04 (patch)
tree830ce2c35100627212caaf732396cafd7bfc1dc8 /fs/namespace.c
parentrpc_pipefs: fix double-dput() (diff)
downloadkernel-qcow2-linux-8e04944f0ea8b838399049bdcda920ab36ae3b04.tar.gz
kernel-qcow2-linux-8e04944f0ea8b838399049bdcda920ab36ae3b04.tar.xz
kernel-qcow2-linux-8e04944f0ea8b838399049bdcda920ab36ae3b04.zip
mm,vmscan: Allow preallocating memory for register_shrinker().
syzbot is catching so many bugs triggered by commit 9ee332d99e4d5a97 ("sget(): handle failures of register_shrinker()"). That commit expected that calling kill_sb() from deactivate_locked_super() without successful fill_super() is safe, but the reality was different; some callers assign attributes which are needed for kill_sb() after sget() succeeds. For example, [1] is a report where sb->s_mode (which seems to be either FMODE_READ | FMODE_EXCL | FMODE_WRITE or FMODE_READ | FMODE_EXCL) is not assigned unless sget() succeeds. But it does not worth complicate sget() so that register_shrinker() failure path can safely call kill_block_super() via kill_sb(). Making alloc_super() fail if memory allocation for register_shrinker() failed is much simpler. Let's avoid calling deactivate_locked_super() from sget_userns() by preallocating memory for the shrinker and making register_shrinker() in sget_userns() never fail. [1] https://syzkaller.appspot.com/bug?id=588996a25a2587be2e3a54e8646728fb9cae44e7 Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Reported-by: syzbot <syzbot+5a170e19c963a2e0df79@syzkaller.appspotmail.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Michal Hocko <mhocko@suse.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/namespace.c')
0 files changed, 0 insertions, 0 deletions