diff options
| author | Trond Myklebust | 2008-02-22 22:34:17 +0100 |
|---|---|---|
| committer | Trond Myklebust | 2008-02-26 06:40:44 +0100 |
| commit | 5d00837b90340af9106dcd93af75fd664c8eb87f (patch) | |
| tree | f537dc84421cf150d66b630e56ea8107078c07a8 /fs/nfs/nfs4state.c | |
| parent | SUNRPC: Convert users of rpc_wake_up_task to use rpc_wake_up_queued_task (diff) | |
| download | kernel-qcow2-linux-5d00837b90340af9106dcd93af75fd664c8eb87f.tar.gz kernel-qcow2-linux-5d00837b90340af9106dcd93af75fd664c8eb87f.tar.xz kernel-qcow2-linux-5d00837b90340af9106dcd93af75fd664c8eb87f.zip | |
SUNRPC: Run rpc timeout functions as callbacks instead of in softirqs
An audit of the current RPC timeout functions shows that they don't really
ever need to run in the softirq context. As long as the softirq is
able to signal that the wakeup is due to a timeout (which it can do by
setting task->tk_status to -ETIMEDOUT) then the callback functions can just
run as standard task->tk_callback functions (in the rpciod/process
context).
The only possible border-line case would be xprt_timer() for the case of
UDP, when the callback is used to reduce the size of the transport
congestion window. In testing, however, the effect of moving that update
to a callback would appear to be minor.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'fs/nfs/nfs4state.c')
| -rw-r--r-- | fs/nfs/nfs4state.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c index b962397004c1..a2ef02824aa8 100644 --- a/fs/nfs/nfs4state.c +++ b/fs/nfs/nfs4state.c @@ -731,7 +731,7 @@ int nfs_wait_on_sequence(struct nfs_seqid *seqid, struct rpc_task *task) list_add_tail(&seqid->list, &sequence->list); if (list_first_entry(&sequence->list, struct nfs_seqid, list) == seqid) goto unlock; - rpc_sleep_on(&sequence->wait, task, NULL, NULL); + rpc_sleep_on(&sequence->wait, task, NULL); status = -EAGAIN; unlock: spin_unlock(&sequence->lock); |