diff options
| author | Chuck Lever | 2019-02-11 17:24:26 +0100 |
|---|---|---|
| committer | Anna Schumaker | 2019-02-13 18:03:21 +0100 |
| commit | f23f658404229278af49284871518174ebbe3580 (patch) | |
| tree | aafee5858f6d88e31ef650bfbce2defb099dd7e2 /fs/nfs/nfs4xdr.c | |
| parent | NFS: Remove print_overflow_msg() (diff) | |
| download | kernel-qcow2-linux-f23f658404229278af49284871518174ebbe3580.tar.gz kernel-qcow2-linux-f23f658404229278af49284871518174ebbe3580.tar.xz kernel-qcow2-linux-f23f658404229278af49284871518174ebbe3580.zip | |
NFS: Add trace events to report non-zero NFS status codes
These can help field troubleshooting without needing the overhead
of a full network capture (ie, tcpdump).
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Diffstat (limited to 'fs/nfs/nfs4xdr.c')
| -rw-r--r-- | fs/nfs/nfs4xdr.c | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c index 24e6a45a5726..38a4cbc18657 100644 --- a/fs/nfs/nfs4xdr.c +++ b/fs/nfs/nfs4xdr.c @@ -54,6 +54,7 @@ #include <linux/nfs_fs.h> #include "nfs4_fs.h" +#include "nfs4trace.h" #include "internal.h" #include "nfs4idmap.h" #include "nfs4session.h" @@ -3188,11 +3189,14 @@ static bool __decode_op_hdr(struct xdr_stream *xdr, enum nfs_opnum4 expected, opnum = be32_to_cpup(p++); if (unlikely(opnum != expected)) goto out_bad_operation; + if (unlikely(*p != cpu_to_be32(NFS_OK))) + goto out_status; + *nfs_retval = 0; + return true; +out_status: nfserr = be32_to_cpup(p); - if (nfserr == NFS_OK) - *nfs_retval = 0; - else - *nfs_retval = nfs4_stat_to_errno(nfserr); + trace_nfs4_xdr_status(opnum, nfserr); + *nfs_retval = nfs4_stat_to_errno(nfserr); return true; out_bad_operation: dprintk("nfs: Server returned operation" |