summaryrefslogtreecommitdiffstats
path: root/fs/nfs/pnfs.c
diff options
context:
space:
mode:
authorElena Reshetova2017-10-20 11:53:31 +0200
committerAnna Schumaker2017-11-17 19:47:59 +0100
commita2a5dea7b6cb77365ed9c987f54d160668c8a95f (patch)
tree97c432cfc80701b303d2708e42dbd3df05b9b376 /fs/nfs/pnfs.c
parentNFSv4.1: Fix up replays of interrupted requests (diff)
downloadkernel-qcow2-linux-a2a5dea7b6cb77365ed9c987f54d160668c8a95f.tar.gz
kernel-qcow2-linux-a2a5dea7b6cb77365ed9c987f54d160668c8a95f.tar.xz
kernel-qcow2-linux-a2a5dea7b6cb77365ed9c987f54d160668c8a95f.zip
fs, nfs: convert nfs4_pnfs_ds.ds_count from atomic_t to refcount_t
atomic_t variables are currently used to implement reference counters with the following properties: - counter is initialized to 1 using atomic_set() - a resource is freed upon counter reaching zero - once counter reaches zero, its further increments aren't allowed - counter schema uses basic atomic operations (set, inc, inc_not_zero, dec_and_test, etc.) Such atomic variables should be converted to a newly provided refcount_t type and API that prevents accidental counter overflows and underflows. This is important since overflows and underflows can lead to use-after-free situation and be exploitable. The variable nfs4_pnfs_ds.ds_count is used as pure reference counter. Convert it to refcount_t and fix up the operations. Suggested-by: Kees Cook <keescook@chromium.org> Reviewed-by: David Windsor <dwindsor@gmail.com> Reviewed-by: Hans Liljestrand <ishkamiel@gmail.com> Signed-off-by: Elena Reshetova <elena.reshetova@intel.com> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Diffstat (limited to 'fs/nfs/pnfs.c')
0 files changed, 0 insertions, 0 deletions