diff options
| author | Benjamin Coddington | 2019-06-11 18:57:52 +0200 |
|---|---|---|
| committer | Trond Myklebust | 2019-07-06 20:54:53 +0200 |
| commit | 9f7761cf0409465075dadb875d5d4b8ef2f890c8 (patch) | |
| tree | 3d45759d163d8a875e3173dd8154d54da85556ee /fs/nfs | |
| parent | nfs: disable client side deduplication (diff) | |
| download | kernel-qcow2-linux-9f7761cf0409465075dadb875d5d4b8ef2f890c8.tar.gz kernel-qcow2-linux-9f7761cf0409465075dadb875d5d4b8ef2f890c8.tar.xz kernel-qcow2-linux-9f7761cf0409465075dadb875d5d4b8ef2f890c8.zip | |
NFS: Cleanup if nfs_match_client is interrupted
Don't bail out before cleaning up a new allocation if the wait for
searching for a matching nfs client is interrupted. Memory leaks.
Reported-by: syzbot+7fe11b49c1cc30e3fce2@syzkaller.appspotmail.com
Fixes: 950a578c6128 ("NFS: make nfs_match_client killable")
Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Diffstat (limited to 'fs/nfs')
| -rw-r--r-- | fs/nfs/client.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/nfs/client.c b/fs/nfs/client.c index e4fa0a5fd183..30838304a0bf 100644 --- a/fs/nfs/client.c +++ b/fs/nfs/client.c @@ -408,10 +408,10 @@ struct nfs_client *nfs_get_client(const struct nfs_client_initdata *cl_init) clp = nfs_match_client(cl_init); if (clp) { spin_unlock(&nn->nfs_client_lock); - if (IS_ERR(clp)) - return clp; if (new) new->rpc_ops->free_client(new); + if (IS_ERR(clp)) + return clp; return nfs_found_client(cl_init, clp); } if (new) { |