diff options
| author | J. Bruce Fields | 2012-04-10 00:06:49 +0200 |
|---|---|---|
| committer | J. Bruce Fields | 2012-04-11 23:49:52 +0200 |
| commit | 9dc4e6c4d1182d34604ea40fef641775f5b15456 (patch) | |
| tree | 22b055349ea646026a97ea0b0cc7da32c18f26dd /fs/nfsd/vfs.c | |
| parent | Linux 3.4-rc2 (diff) | |
| download | kernel-qcow2-linux-9dc4e6c4d1182d34604ea40fef641775f5b15456.tar.gz kernel-qcow2-linux-9dc4e6c4d1182d34604ea40fef641775f5b15456.tar.xz kernel-qcow2-linux-9dc4e6c4d1182d34604ea40fef641775f5b15456.zip | |
nfsd: don't fail unchecked creates of non-special files
Allow a v3 unchecked open of a non-regular file succeed as if it were a
lookup; typically a client in such a case will want to fall back on a
local open, so succeeding and giving it the filehandle is more useful
than failing with nfserr_exist, which makes it appear that nothing at
all exists by that name.
Similarly for v4, on an open-create, return the same errors we would on
an attempt to open a non-regular file, instead of returning
nfserr_exist.
This fixes a problem found doing a v4 open of a symlink with
O_RDONLY|O_CREAT, which resulted in the current client returning EEXIST.
Thanks also to Trond for analysis.
Cc: stable@kernel.org
Reported-by: Orion Poplawski <orion@cora.nwra.com>
Tested-by: Orion Poplawski <orion@cora.nwra.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs/nfsd/vfs.c')
| -rw-r--r-- | fs/nfsd/vfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index 296d671654d6..568666156ea4 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c @@ -1458,7 +1458,7 @@ do_nfsd_create(struct svc_rqst *rqstp, struct svc_fh *fhp, switch (createmode) { case NFS3_CREATE_UNCHECKED: if (! S_ISREG(dchild->d_inode->i_mode)) - err = nfserr_exist; + goto out; else if (truncp) { /* in nfsv4, we need to treat this case a little * differently. we don't want to truncate the |