diff options
| author | Al Viro | 2016-04-11 00:50:48 +0200 |
|---|---|---|
| committer | Al Viro | 2016-04-11 01:31:09 +0200 |
| commit | 79a628d14ec7ee9adfdc3ce04343d5ff7ec20c18 (patch) | |
| tree | 96b0e5a6a97bed3bdd0669bbdf372f05db718404 /fs/reiserfs/file.c | |
| parent | cifs: kill more bogus checks in ->...xattr() methods (diff) | |
| download | kernel-qcow2-linux-79a628d14ec7ee9adfdc3ce04343d5ff7ec20c18.tar.gz kernel-qcow2-linux-79a628d14ec7ee9adfdc3ce04343d5ff7ec20c18.tar.xz kernel-qcow2-linux-79a628d14ec7ee9adfdc3ce04343d5ff7ec20c18.zip | |
reiserfs: switch to generic_{get,set,remove}xattr()
reiserfs_xattr_[sg]et() will fail with -EOPNOTSUPP for V1 inodes anyway,
and all reiserfs instances of ->[sg]et() call it and so does ->set_acl().
Checks for name length in the instances had been bogus; they should've
been "bugger off if it's _exactly_ the prefix" (as generic would
do on its own) and not "bugger off if it's shorter than the prefix" -
that can't happen.
xattr_full_name() is needed to adjust for the fact that generic instances
will skip the prefix in the name passed to ->[gs]et(); reiserfs homegrown
analogues didn't.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/reiserfs/file.c')
| -rw-r--r-- | fs/reiserfs/file.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/reiserfs/file.c b/fs/reiserfs/file.c index 9424a4ba93a9..9ffaf7145644 100644 --- a/fs/reiserfs/file.c +++ b/fs/reiserfs/file.c @@ -260,10 +260,10 @@ const struct file_operations reiserfs_file_operations = { const struct inode_operations reiserfs_file_inode_operations = { .setattr = reiserfs_setattr, - .setxattr = reiserfs_setxattr, - .getxattr = reiserfs_getxattr, + .setxattr = generic_setxattr, + .getxattr = generic_getxattr, .listxattr = reiserfs_listxattr, - .removexattr = reiserfs_removexattr, + .removexattr = generic_removexattr, .permission = reiserfs_permission, .get_acl = reiserfs_get_acl, .set_acl = reiserfs_set_acl, |