summaryrefslogtreecommitdiffstats
path: root/fs/select.c
diff options
context:
space:
mode:
authorOleg Nesterov2014-01-22 00:50:00 +0100
committerLinus Torvalds2014-01-22 01:19:46 +0100
commitad96244179fbd55b40c00f10f399bc04739b8e1f (patch)
tree8bb173d243351b07f38cce9e6bb1b67db628222f /fs/select.c
parentoom_kill: change oom_kill.c to use for_each_thread() (diff)
downloadkernel-qcow2-linux-ad96244179fbd55b40c00f10f399bc04739b8e1f.tar.gz
kernel-qcow2-linux-ad96244179fbd55b40c00f10f399bc04739b8e1f.tar.xz
kernel-qcow2-linux-ad96244179fbd55b40c00f10f399bc04739b8e1f.zip
oom_kill: has_intersects_mems_allowed() needs rcu_read_lock()
At least out_of_memory() calls has_intersects_mems_allowed() without even rcu_read_lock(), this is obviously buggy. Add the necessary rcu_read_lock(). This means that we can not simply return from the loop, we need "bool ret" and "break". While at it, swap the names of task_struct's (the argument and the local). This cleans up the code a little bit and avoids the unnecessary initialization. Signed-off-by: Oleg Nesterov <oleg@redhat.com> Reviewed-by: Sergey Dyasly <dserrg@gmail.com> Tested-by: Sergey Dyasly <dserrg@gmail.com> Reviewed-by: Sameer Nanda <snanda@chromium.org> Cc: "Eric W. Biederman" <ebiederm@xmission.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Mandeep Singh Baines <msb@chromium.org> Cc: "Ma, Xindong" <xindong.ma@intel.com> Reviewed-by: Michal Hocko <mhocko@suse.cz> Cc: "Tu, Xiaobing" <xiaobing.tu@intel.com> Acked-by: David Rientjes <rientjes@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/select.c')
0 files changed, 0 insertions, 0 deletions