diff options
| author | Darrick J. Wong | 2017-03-06 20:58:20 +0100 |
|---|---|---|
| committer | Darrick J. Wong | 2017-03-08 05:10:50 +0100 |
| commit | 08b005f1333154ae5b404ca28766e0ffb9f1c150 (patch) | |
| tree | 5179a760a440e2a62b4058b8811200234cd3c934 /fs/xfs/kmem.h | |
| parent | xfs: Use xfs_icluster_size_fsb() to calculate inode alignment mask (diff) | |
| download | kernel-qcow2-linux-08b005f1333154ae5b404ca28766e0ffb9f1c150.tar.gz kernel-qcow2-linux-08b005f1333154ae5b404ca28766e0ffb9f1c150.tar.xz kernel-qcow2-linux-08b005f1333154ae5b404ca28766e0ffb9f1c150.zip | |
xfs: remove kmem_zalloc_greedy
The sole remaining caller of kmem_zalloc_greedy is bulkstat, which uses
it to grab 1-4 pages for staging of inobt records. The infinite loop in
the greedy allocation function is causing hangs[1] in generic/269, so
just get rid of the greedy allocator in favor of kmem_zalloc_large.
This makes bulkstat somewhat more likely to ENOMEM if there's really no
pages to spare, but eliminates a source of hangs.
[1] http://lkml.kernel.org/r/20170301044634.rgidgdqqiiwsmfpj%40XZHOUW.usersys.redhat.com
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
v2: remove single-page fallback
Diffstat (limited to 'fs/xfs/kmem.h')
| -rw-r--r-- | fs/xfs/kmem.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/xfs/kmem.h b/fs/xfs/kmem.h index 689f746224e7..f0fc84fcaac2 100644 --- a/fs/xfs/kmem.h +++ b/fs/xfs/kmem.h @@ -69,8 +69,6 @@ static inline void kmem_free(const void *ptr) } -extern void *kmem_zalloc_greedy(size_t *, size_t, size_t); - static inline void * kmem_zalloc(size_t size, xfs_km_flags_t flags) { |