diff options
| author | Darrick J. Wong | 2017-11-06 20:46:15 +0100 |
|---|---|---|
| committer | Darrick J. Wong | 2017-11-09 18:10:45 +0100 |
| commit | 0a1e1567b386b96c710d385181330c13ca03ffe3 (patch) | |
| tree | 957b4f93ef93372b595f48f45a7b5c22f144fbe9 /fs/xfs/scrub/common.h | |
| parent | xfs: refactor the directory data block bestfree checks (diff) | |
| download | kernel-qcow2-linux-0a1e1567b386b96c710d385181330c13ca03ffe3.tar.gz kernel-qcow2-linux-0a1e1567b386b96c710d385181330c13ca03ffe3.tar.xz kernel-qcow2-linux-0a1e1567b386b96c710d385181330c13ca03ffe3.zip | |
xfs: pass inode number to xfs_scrub_ino_set_{preen,warning}
There are two ways to scrub an inode -- calling xfs_iget and checking
the raw inode core, or by loading the inode cluster buffer and checking
the on-disk contents directly. The second method is only useful if
_iget fails the verifiers; when this is the case, sc->ip is NULL and
calling the tracepoint will cause a system crash.
Therefore, pass the raw inode number directly into the _preen and
_warning functions.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Diffstat (limited to 'fs/xfs/scrub/common.h')
| -rw-r--r-- | fs/xfs/scrub/common.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/xfs/scrub/common.h b/fs/xfs/scrub/common.h index 0409ec2e1300..5c043855570e 100644 --- a/fs/xfs/scrub/common.h +++ b/fs/xfs/scrub/common.h @@ -58,7 +58,8 @@ bool xfs_scrub_fblock_process_error(struct xfs_scrub_context *sc, int whichfork, void xfs_scrub_block_set_preen(struct xfs_scrub_context *sc, struct xfs_buf *bp); -void xfs_scrub_ino_set_preen(struct xfs_scrub_context *sc, struct xfs_buf *bp); +void xfs_scrub_ino_set_preen(struct xfs_scrub_context *sc, xfs_ino_t ino, + struct xfs_buf *bp); void xfs_scrub_block_set_corrupt(struct xfs_scrub_context *sc, struct xfs_buf *bp); @@ -67,7 +68,7 @@ void xfs_scrub_ino_set_corrupt(struct xfs_scrub_context *sc, xfs_ino_t ino, void xfs_scrub_fblock_set_corrupt(struct xfs_scrub_context *sc, int whichfork, xfs_fileoff_t offset); -void xfs_scrub_ino_set_warning(struct xfs_scrub_context *sc, +void xfs_scrub_ino_set_warning(struct xfs_scrub_context *sc, xfs_ino_t ino, struct xfs_buf *bp); void xfs_scrub_fblock_set_warning(struct xfs_scrub_context *sc, int whichfork, xfs_fileoff_t offset); |