summaryrefslogtreecommitdiffstats
path: root/fs/xfs/scrub
diff options
context:
space:
mode:
authorDarrick J. Wong2019-02-01 18:08:54 +0100
committerDarrick J. Wong2019-02-12 01:06:40 +0100
commit654805367d982cffdb9979453673aab9c3c96d07 (patch)
treec224d814747294d0f688c08dc7513b63a36916e4 /fs/xfs/scrub
parentxfs: check directory name validity (diff)
downloadkernel-qcow2-linux-654805367d982cffdb9979453673aab9c3c96d07.tar.gz
kernel-qcow2-linux-654805367d982cffdb9979453673aab9c3c96d07.tar.xz
kernel-qcow2-linux-654805367d982cffdb9979453673aab9c3c96d07.zip
xfs: check attribute name validity
Check extended attribute entry names for invalid characters. Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Reviewed-by: Brian Foster <bfoster@redhat.com>
Diffstat (limited to 'fs/xfs/scrub')
-rw-r--r--fs/xfs/scrub/attr.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/fs/xfs/scrub/attr.c b/fs/xfs/scrub/attr.c
index 9960bc5b5d76..dce74ec57038 100644
--- a/fs/xfs/scrub/attr.c
+++ b/fs/xfs/scrub/attr.c
@@ -93,6 +93,12 @@ xchk_xattr_listent(
return;
}
+ /* Does this name make sense? */
+ if (!xfs_attr_namecheck(name, namelen)) {
+ xchk_fblock_set_corrupt(sx->sc, XFS_ATTR_FORK, args.blkno);
+ return;
+ }
+
args.flags = ATTR_KERNOTIME;
if (flags & XFS_ATTR_ROOT)
args.flags |= ATTR_ROOT;