diff options
| author | Vratislav Bendel | 2018-03-07 02:07:44 +0100 |
|---|---|---|
| committer | Darrick J. Wong | 2018-03-12 04:27:56 +0100 |
| commit | 19957a181608d25c8f4136652d0ea00b3738972d (patch) | |
| tree | 260a3628b145cac035ad04785faaa4912b02dc52 /fs/xfs/xfs_buf.c | |
| parent | xfs: fix transaction allocation deadlock in IO path (diff) | |
| download | kernel-qcow2-linux-19957a181608d25c8f4136652d0ea00b3738972d.tar.gz kernel-qcow2-linux-19957a181608d25c8f4136652d0ea00b3738972d.tar.xz kernel-qcow2-linux-19957a181608d25c8f4136652d0ea00b3738972d.zip | |
xfs: Correctly invert xfs_buftarg LRU isolation logic
Due to an inverted logic mistake in xfs_buftarg_isolate()
the xfs_buffers with zero b_lru_ref will take another trip
around LRU, while isolating buffers with non-zero b_lru_ref.
Additionally those isolated buffers end up right back on the LRU
once they are released, because b_lru_ref remains elevated.
Fix that circuitous route by leaving them on the LRU
as originally intended.
Signed-off-by: Vratislav Bendel <vbendel@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Diffstat (limited to 'fs/xfs/xfs_buf.c')
| -rw-r--r-- | fs/xfs/xfs_buf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index d1da2ee9e6db..ac669a10c62f 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@ -1708,7 +1708,7 @@ xfs_buftarg_isolate( * zero. If the value is already zero, we need to reclaim the * buffer, otherwise it gets another trip through the LRU. */ - if (!atomic_add_unless(&bp->b_lru_ref, -1, 0)) { + if (atomic_add_unless(&bp->b_lru_ref, -1, 0)) { spin_unlock(&bp->b_lock); return LRU_ROTATE; } |