diff options
author | Eric Sandeen | 2012-03-30 18:24:11 +0200 |
---|---|---|
committer | Ben Myers | 2013-08-30 22:20:50 +0200 |
commit | 914ed44b17dc30ce0d783e8e23fce58a1a92412c (patch) | |
tree | 292c7c14d4c6952c8e12c09afd51ece7901cf5ed /fs/xfs/xfs_dir2.h | |
parent | xfs: finish removing IOP_* macros. (diff) | |
download | kernel-qcow2-linux-914ed44b17dc30ce0d783e8e23fce58a1a92412c.tar.gz kernel-qcow2-linux-914ed44b17dc30ce0d783e8e23fce58a1a92412c.tar.xz kernel-qcow2-linux-914ed44b17dc30ce0d783e8e23fce58a1a92412c.zip |
Fix wrong flag ASSERT in xfs_attr_shortform_getvalue
This ASSERT is testing an if_flags flag value against
a di_aformat enum value. di_aformat is never assigned
XFS_IFINLINE.
This happens to work for now, because XFS_IFINLINE has
the same value as XFS_DINODE_FMT_LOCAL, and that's tested
just before we call this function.
However, I think the intention is to assert that we have
read in the data, i.e. XFS_IFINLINE on if_flags, before
we use if_data. This is done in other places through the
code as well.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_dir2.h')
0 files changed, 0 insertions, 0 deletions