diff options
| author | Brian Foster | 2017-06-27 18:52:32 +0200 |
|---|---|---|
| committer | Darrick J. Wong | 2017-06-28 03:23:21 +0200 |
| commit | 3e88a0078ba8ef61816c85d33131827b4a307852 (patch) | |
| tree | 5ba0313c626653a569701246cdef5e07d6ae7012 /fs/xfs/xfs_log.c | |
| parent | xfs: convert drop_writes to use the errortag mechanism (diff) | |
| download | kernel-qcow2-linux-3e88a0078ba8ef61816c85d33131827b4a307852.tar.gz kernel-qcow2-linux-3e88a0078ba8ef61816c85d33131827b4a307852.tar.xz kernel-qcow2-linux-3e88a0078ba8ef61816c85d33131827b4a307852.zip | |
xfs: replace log_badcrc_factor knob with error injection tag
Now that error injection tags support dynamic frequency adjustment,
replace the debug mode sysfs knob that controls log record CRC error
injection with an error injection tag.
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Diffstat (limited to 'fs/xfs/xfs_log.c')
| -rw-r--r-- | fs/xfs/xfs_log.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c index 2d1112ee1f86..31f11be42f01 100644 --- a/fs/xfs/xfs_log.c +++ b/fs/xfs/xfs_log.c @@ -1841,7 +1841,6 @@ xlog_sync( /* calculcate the checksum */ iclog->ic_header.h_crc = xlog_cksum(log, &iclog->ic_header, iclog->ic_datap, size); -#ifdef DEBUG /* * Intentionally corrupt the log record CRC based on the error injection * frequency, if defined. This facilitates testing log recovery in the @@ -1849,15 +1848,13 @@ xlog_sync( * write on I/O completion and shutdown the fs. The subsequent mount * detects the bad CRC and attempts to recover. */ - if (log->l_badcrc_factor && - (prandom_u32() % log->l_badcrc_factor == 0)) { + if (XFS_TEST_ERROR(false, log->l_mp, XFS_ERRTAG_LOG_BAD_CRC)) { iclog->ic_header.h_crc &= cpu_to_le32(0xAAAAAAAA); iclog->ic_state |= XLOG_STATE_IOABORT; xfs_warn(log->l_mp, "Intentionally corrupted log record at LSN 0x%llx. Shutdown imminent.", be64_to_cpu(iclog->ic_header.h_lsn)); } -#endif bp->b_io_length = BTOBB(count); bp->b_fspriv = iclog; |