diff options
| author | Christoph Hellwig | 2019-06-29 04:31:37 +0200 |
|---|---|---|
| committer | Darrick J. Wong | 2019-06-30 18:05:17 +0200 |
| commit | fe64e0d26b1c8096073661851edc99d6370f5e96 (patch) | |
| tree | 0664e1bab2c40ddb80e551d48ff367fb55730a17 /fs/xfs | |
| parent | xfs: allow merging ioends over append boundaries (diff) | |
| download | kernel-qcow2-linux-fe64e0d26b1c8096073661851edc99d6370f5e96.tar.gz kernel-qcow2-linux-fe64e0d26b1c8096073661851edc99d6370f5e96.tar.xz kernel-qcow2-linux-fe64e0d26b1c8096073661851edc99d6370f5e96.zip | |
xfs: simplify xfs_ioend_can_merge
Compare the block layer status directly instead of converting it to
an errno first.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Diffstat (limited to 'fs/xfs')
| -rw-r--r-- | fs/xfs/xfs_aops.c | 14 |
1 files changed, 2 insertions, 12 deletions
diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index 84fca91dacf1..326294a4918f 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c @@ -285,13 +285,9 @@ done: static bool xfs_ioend_can_merge( struct xfs_ioend *ioend, - int ioend_error, struct xfs_ioend *next) { - int next_error; - - next_error = blk_status_to_errno(next->io_bio->bi_status); - if (ioend_error != next_error) + if (ioend->io_bio->bi_status != next->io_bio->bi_status) return false; if ((ioend->io_fork == XFS_COW_FORK) ^ (next->io_fork == XFS_COW_FORK)) return false; @@ -329,17 +325,11 @@ xfs_ioend_try_merge( struct list_head *more_ioends) { struct xfs_ioend *next_ioend; - int ioend_error; - - if (list_empty(more_ioends)) - return; - - ioend_error = blk_status_to_errno(ioend->io_bio->bi_status); while (!list_empty(more_ioends)) { next_ioend = list_first_entry(more_ioends, struct xfs_ioend, io_list); - if (!xfs_ioend_can_merge(ioend, ioend_error, next_ioend)) + if (!xfs_ioend_can_merge(ioend, next_ioend)) break; list_move_tail(&next_ioend->io_list, &ioend->io_list); ioend->io_size += next_ioend->io_size; |