diff options
| author | Haicheng Li | 2013-10-18 11:24:08 +0200 |
|---|---|---|
| committer | Jaegeuk Kim | 2013-10-22 12:57:31 +0200 |
| commit | 435f2a1b58ac8f50894f23549c97791085f7cba2 (patch) | |
| tree | 6f8bfb66fc20019dedbafc9215ce7abb46b0d2a7 /fs | |
| parent | f2fs: use true and false for boolean value (diff) | |
| download | kernel-qcow2-linux-435f2a1b58ac8f50894f23549c97791085f7cba2.tar.gz kernel-qcow2-linux-435f2a1b58ac8f50894f23549c97791085f7cba2.tar.xz kernel-qcow2-linux-435f2a1b58ac8f50894f23549c97791085f7cba2.zip | |
f2fs: no need to check other dirty_segmap when the seg has been found
Because one dirty seg can only be mapped to one dirty_type. Otherwise, it's a bug.
Signed-off-by: Haicheng Li <haicheng.li@linux.intel.com>
[Jaegeuk Kim: modify a comment related to this patch]
Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/f2fs/segment.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 862fef3ae253..8ac161965242 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -78,10 +78,14 @@ static void __remove_dirty_segment(struct f2fs_sb_info *sbi, unsigned int segno, if (dirty_type == DIRTY) { enum dirty_type t = DIRTY_HOT_DATA; - /* clear all the bitmaps */ - for (; t <= DIRTY_COLD_NODE; t++) - if (test_and_clear_bit(segno, dirty_i->dirty_segmap[t])) + /* clear its dirty bitmap */ + for (; t <= DIRTY_COLD_NODE; t++) { + if (test_and_clear_bit(segno, + dirty_i->dirty_segmap[t])) { dirty_i->nr_dirty[t]--; + break; + } + } if (get_valid_blocks(sbi, segno, sbi->segs_per_sec) == 0) clear_bit(GET_SECNO(sbi, segno), |