diff options
| author | Chengguang Xu | 2018-06-13 06:05:13 +0200 |
|---|---|---|
| committer | Al Viro | 2018-10-18 08:04:59 +0200 |
| commit | 515f1867addaba49c1c6ac73abfaffbc192c1db4 (patch) | |
| tree | fbddee5d65ec3b1156b6e0343bfb4d164593b71f /fs | |
| parent | Delete invalid assignment statements in do_sendfile (diff) | |
| download | kernel-qcow2-linux-515f1867addaba49c1c6ac73abfaffbc192c1db4.tar.gz kernel-qcow2-linux-515f1867addaba49c1c6ac73abfaffbc192c1db4.tar.xz kernel-qcow2-linux-515f1867addaba49c1c6ac73abfaffbc192c1db4.zip | |
fs/exofs: fix potential memory leak in mount option parsing
There are some cases can cause memory leak when parsing
option 'osdname'.
Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/exofs/super.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/exofs/super.c b/fs/exofs/super.c index 41cf2fbee50d..7d61e3fa378c 100644 --- a/fs/exofs/super.c +++ b/fs/exofs/super.c @@ -101,6 +101,7 @@ static int parse_options(char *options, struct exofs_mountopt *opts) token = match_token(p, tokens, args); switch (token) { case Opt_name: + kfree(opts->dev_name); opts->dev_name = match_strdup(&args[0]); if (unlikely(!opts->dev_name)) { EXOFS_ERR("Error allocating dev_name"); @@ -866,8 +867,10 @@ static struct dentry *exofs_mount(struct file_system_type *type, int ret; ret = parse_options(data, &opts); - if (ret) + if (ret) { + kfree(opts.dev_name); return ERR_PTR(ret); + } if (!opts.dev_name) opts.dev_name = dev_name; |