diff options
| author | Nikolay Borisov | 2018-02-08 17:25:17 +0100 |
|---|---|---|
| committer | David Sterba | 2018-03-26 15:09:34 +0200 |
| commit | bf6d7d4900c0d0c15dcd1baa1b65e6519bf4abef (patch) | |
| tree | af6cf80ca87a3cf2fa9004e514a130123ff372a3 /fs | |
| parent | btrfs: log, when replace, is canceled by the user (diff) | |
| download | kernel-qcow2-linux-bf6d7d4900c0d0c15dcd1baa1b65e6519bf4abef.tar.gz kernel-qcow2-linux-bf6d7d4900c0d0c15dcd1baa1b65e6519bf4abef.tar.xz kernel-qcow2-linux-bf6d7d4900c0d0c15dcd1baa1b65e6519bf4abef.zip | |
btrfs: Remove invalid null checks from btrfs_cleanup_dirty_bgs
list_first_entry is essentially a wrapper over cotnainer_of. The latter
can never return null even if it's working on inconsistent list since it
will either crash or return some offset in the wrong struct.
Additionally, for the dirty_bgs list the iteration is done under
dirty_bgs_lock which ensures consistency of the list.
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Liu Bo <bo.li.liu@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/btrfs/disk-io.c | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 47624407bb94..dcfdb1f17f1b 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -4327,11 +4327,6 @@ void btrfs_cleanup_dirty_bgs(struct btrfs_transaction *cur_trans, cache = list_first_entry(&cur_trans->dirty_bgs, struct btrfs_block_group_cache, dirty_list); - if (!cache) { - btrfs_err(fs_info, "orphan block group dirty_bgs list"); - spin_unlock(&cur_trans->dirty_bgs_lock); - return; - } if (!list_empty(&cache->io_list)) { spin_unlock(&cur_trans->dirty_bgs_lock); @@ -4355,10 +4350,6 @@ void btrfs_cleanup_dirty_bgs(struct btrfs_transaction *cur_trans, cache = list_first_entry(&cur_trans->io_bgs, struct btrfs_block_group_cache, io_list); - if (!cache) { - btrfs_err(fs_info, "orphan block group on io_bgs list"); - return; - } list_del_init(&cache->io_list); spin_lock(&cache->lock); |