diff options
| author | Arnd Bergmann | 2016-11-08 14:28:19 +0100 |
|---|---|---|
| committer | Pablo Neira Ayuso | 2016-11-10 00:19:33 +0100 |
| commit | 56a62e2218f544258bd1796889a42f4516ccd04a (patch) | |
| tree | e333c98a7c95fff7d3f24be050f8202e6b0792f1 /include/linux/pps_kernel.h | |
| parent | udp: provide udp{4,6}_lib_lookup for nf_socket_ipv{4,6} (diff) | |
| download | kernel-qcow2-linux-56a62e2218f544258bd1796889a42f4516ccd04a.tar.gz kernel-qcow2-linux-56a62e2218f544258bd1796889a42f4516ccd04a.tar.xz kernel-qcow2-linux-56a62e2218f544258bd1796889a42f4516ccd04a.zip | |
netfilter: conntrack: fix NF_REPEAT handling
gcc correctly identified a theoretical uninitialized variable use:
net/netfilter/nf_conntrack_core.c: In function 'nf_conntrack_in':
net/netfilter/nf_conntrack_core.c:1125:14: error: 'l4proto' may be used uninitialized in this function [-Werror=maybe-uninitialized]
This could only happen when we 'goto out' before looking up l4proto,
and then enter the retry, implying that l3proto->get_l4proto()
returned NF_REPEAT. This does not currently get returned in any
code path and probably won't ever happen, but is not good to
rely on.
Moving the repeat handling up a little should have the same
behavior as today but avoids the warning by making that case
impossible to enter.
[ I have mangled this original patch to remove the check for tmpl, we
should inconditionally jump back to the repeat label in case we hit
NF_REPEAT instead. I have also moved the comment that explains this
where it belongs. --pablo ]
Fixes: 08733a0cb7de ("netfilter: handle NF_REPEAT from nf_conntrack_in()")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'include/linux/pps_kernel.h')
0 files changed, 0 insertions, 0 deletions