summaryrefslogtreecommitdiffstats
path: root/include/linux/serdev.h
diff options
context:
space:
mode:
authorJohan Hovold2017-11-03 15:30:53 +0100
committerGreg Kroah-Hartman2017-11-28 16:00:50 +0100
commitfd00cf81a9a84776ba58e56bd042c726dcf75cf3 (patch)
tree446b6b8cc297eb266c1d4d50995be2acdd9b2b01 /include/linux/serdev.h
parentserdev: ttyport: add missing receive_buf sanity checks (diff)
downloadkernel-qcow2-linux-fd00cf81a9a84776ba58e56bd042c726dcf75cf3.tar.gz
kernel-qcow2-linux-fd00cf81a9a84776ba58e56bd042c726dcf75cf3.tar.xz
kernel-qcow2-linux-fd00cf81a9a84776ba58e56bd042c726dcf75cf3.zip
serdev: fix receive_buf return value when no callback
The receive_buf callback is supposed to return the number of bytes processed and should specifically not return a negative errno. Due to missing sanity checks in the serdev tty-port controller, a driver not providing a receive_buf callback could cause the flush_to_ldisc() worker to spin in a tight loop when the tty buffer pointers are incremented with -EINVAL (-22). The missing sanity checks have now been added to the tty-port controller, but let's fix up the serdev-controller helper as well. Signed-off-by: Johan Hovold <johan@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/linux/serdev.h')
-rw-r--r--include/linux/serdev.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/serdev.h b/include/linux/serdev.h
index e69402d4a8ae..d609e6dc5bad 100644
--- a/include/linux/serdev.h
+++ b/include/linux/serdev.h
@@ -184,7 +184,7 @@ static inline int serdev_controller_receive_buf(struct serdev_controller *ctrl,
struct serdev_device *serdev = ctrl->serdev;
if (!serdev || !serdev->ops->receive_buf)
- return -EINVAL;
+ return 0;
return serdev->ops->receive_buf(serdev, data, count);
}