diff options
| author | David S. Miller | 2013-12-27 19:04:33 +0100 |
|---|---|---|
| committer | David S. Miller | 2013-12-27 19:04:33 +0100 |
| commit | 73409f3b0ff0ae7bc1f647936b23e6d5d5dcbe28 (patch) | |
| tree | 51dbcef70dc3b374e6e720aa5fde10f783301277 /include/linux/skbuff.h | |
| parent | arc_emac: fix potential use after free (diff) | |
| download | kernel-qcow2-linux-73409f3b0ff0ae7bc1f647936b23e6d5d5dcbe28.tar.gz kernel-qcow2-linux-73409f3b0ff0ae7bc1f647936b23e6d5d5dcbe28.tar.xz kernel-qcow2-linux-73409f3b0ff0ae7bc1f647936b23e6d5d5dcbe28.zip | |
net: Add some clarification to skb_tx_timestamp() comment.
We've seen so many instances of people invoking skb_tx_timestamp()
after the device already has been given the packet, that it's worth
being a little bit more verbose and explicit in this comment.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux/skbuff.h')
| -rw-r--r-- | include/linux/skbuff.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 6aae83890520..6f69b3f914fb 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -2531,6 +2531,10 @@ static inline void sw_tx_timestamp(struct sk_buff *skb) * Ethernet MAC Drivers should call this function in their hard_xmit() * function immediately before giving the sk_buff to the MAC hardware. * + * Specifically, one should make absolutely sure that this function is + * called before TX completion of this packet can trigger. Otherwise + * the packet could potentially already be freed. + * * @skb: A socket buffer. */ static inline void skb_tx_timestamp(struct sk_buff *skb) |