diff options
author | Fabio Estevam | 2014-09-22 22:55:29 +0200 |
---|---|---|
committer | David S. Miller | 2014-09-26 21:39:59 +0200 |
commit | aebac744932439b5f869869f07f406a9cced465d (patch) | |
tree | ee80643e5dd8e156ad23b492874f5409cd44f1e9 /include/linux/skbuff.h | |
parent | Merge tag 'master-2014-09-16' of git://git.kernel.org/pub/scm/linux/kernel/gi... (diff) | |
download | kernel-qcow2-linux-aebac744932439b5f869869f07f406a9cced465d.tar.gz kernel-qcow2-linux-aebac744932439b5f869869f07f406a9cced465d.tar.xz kernel-qcow2-linux-aebac744932439b5f869869f07f406a9cced465d.zip |
fec: Remove fec_enet_select_queue()
Sparse complains about fec_enet_select_queue() not being static.
Feedback from David Miller [1] was to remove this function instead of making it
static:
"Please just delete this function.
It's overriding code which does exactly the same thing.
Actually, more precisely, this code is duplicating code in a way that
bypasses many core facilitites of the networking. For example, this
override means that socket based flow steering, XPS, etc. are all
not happening on these devices.
Without ->ndo_select_queue(), the flow dissector does __netdev_pick_tx
which is exactly what you want to happen."
[1] http://www.spinics.net/lists/netdev/msg297653.html
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux/skbuff.h')
0 files changed, 0 insertions, 0 deletions