diff options
| author | Tao Ma | 2011-03-03 16:53:20 +0100 |
|---|---|---|
| committer | Jens Axboe | 2011-03-03 16:53:20 +0100 |
| commit | 2d3a8497f8cc5aca14b722cd37d51f6c15ff9f74 (patch) | |
| tree | 2e0013fdc1eec486a425e666a885b04a1c37befb /include/linux | |
| parent | block: blk-flush shouldn't call directly into q->request_fn() __blk_run_queue() (diff) | |
| download | kernel-qcow2-linux-2d3a8497f8cc5aca14b722cd37d51f6c15ff9f74.tar.gz kernel-qcow2-linux-2d3a8497f8cc5aca14b722cd37d51f6c15ff9f74.tar.xz kernel-qcow2-linux-2d3a8497f8cc5aca14b722cd37d51f6c15ff9f74.zip | |
blktrace: Remove blk_fill_rwbs_rq.
If we enable trace events to trace block actions, We use
blk_fill_rwbs_rq to analyze the corresponding actions
in request's cmd_flags, but we only choose the minor 2 bits
from it, so most of other flags(e.g, REQ_SYNC) are missing.
For example, with a sync write we get:
write_test-2409 [001] 160.013869: block_rq_insert: 3,64 W 0 () 258135 + =
8 [write_test]
Since now we have integrated the flags of both bio and request,
it is safe to pass rq->cmd_flags directly to blk_fill_rwbs and
blk_fill_rwbs_rq isn't needed any more.
With this patch, after a sync write we get:
write_test-2417 [000] 226.603878: block_rq_insert: 3,64 WS 0 () 258135 +=
8 [write_test]
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Acked-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Diffstat (limited to 'include/linux')
| -rw-r--r-- | include/linux/blktrace_api.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/linux/blktrace_api.h b/include/linux/blktrace_api.h index 3395cf7130f5..b22fb0d3db0f 100644 --- a/include/linux/blktrace_api.h +++ b/include/linux/blktrace_api.h @@ -245,7 +245,6 @@ static inline int blk_cmd_buf_len(struct request *rq) extern void blk_dump_cmd(char *buf, struct request *rq); extern void blk_fill_rwbs(char *rwbs, u32 rw, int bytes); -extern void blk_fill_rwbs_rq(char *rwbs, struct request *rq); #endif /* CONFIG_EVENT_TRACING && CONFIG_BLOCK */ |