diff options
| author | Chuck Lever | 2011-01-21 04:05:28 +0100 |
|---|---|---|
| committer | Trond Myklebust | 2011-01-25 21:24:47 +0100 |
| commit | 731f3f482ad3b2c58a1af2d0a9a634a82803706a (patch) | |
| tree | 1425c239481309ffc68dd33a991fc13fc309226c /include/linux | |
| parent | NFS: Fix "kernel BUG at fs/nfs/nfs3xdr.c:1338!" (diff) | |
| download | kernel-qcow2-linux-731f3f482ad3b2c58a1af2d0a9a634a82803706a.tar.gz kernel-qcow2-linux-731f3f482ad3b2c58a1af2d0a9a634a82803706a.tar.xz kernel-qcow2-linux-731f3f482ad3b2c58a1af2d0a9a634a82803706a.zip | |
NFS: nfsacl_{encode,decode} should return signed integer
Clean up.
The nfsacl_encode() and nfsacl_decode() functions return negative
errno values, and each call site verifies that the returned value
is not negative. Change the synopsis of both of these functions
to reflect this usage.
Document the synopsis and return values.
Reported-by: Trond Myklebust <trond.myklebust@netapp.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'include/linux')
| -rw-r--r-- | include/linux/nfsacl.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/linux/nfsacl.h b/include/linux/nfsacl.h index f321b578edeb..fabcb1e5c460 100644 --- a/include/linux/nfsacl.h +++ b/include/linux/nfsacl.h @@ -51,10 +51,10 @@ nfsacl_size(struct posix_acl *acl_access, struct posix_acl *acl_default) return w; } -extern unsigned int +extern int nfsacl_encode(struct xdr_buf *buf, unsigned int base, struct inode *inode, struct posix_acl *acl, int encode_entries, int typeflag); -extern unsigned int +extern int nfsacl_decode(struct xdr_buf *buf, unsigned int base, unsigned int *aclcnt, struct posix_acl **pacl); |