summaryrefslogtreecommitdiffstats
path: root/include/scsi
diff options
context:
space:
mode:
authorBart Van Assche2017-08-25 22:46:28 +0200
committerMartin K. Petersen2017-08-25 23:08:07 +0200
commitc2e872a27c610a5e2a71444f86470f765ed9dfce (patch)
tree34404a5b478f15d88bcc9f906c6eb9f9dbd422f0 /include/scsi
parentscsi: Remove an obsolete function declaration (diff)
downloadkernel-qcow2-linux-c2e872a27c610a5e2a71444f86470f765ed9dfce.tar.gz
kernel-qcow2-linux-c2e872a27c610a5e2a71444f86470f765ed9dfce.tar.xz
kernel-qcow2-linux-c2e872a27c610a5e2a71444f86470f765ed9dfce.zip
scsi: Avoid sign extension of scsi_device.type
This patch avoids that smatch reports the following: drivers/scsi/scsi_sysfs.c:506 scsi_bus_uevent() warn: argument 3 to %02x specifier has type 'char' drivers/scsi/scsi_sysfs.c:872 sdev_show_modalias() warn: argument 4 to %02x specifier has type 'char' Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Hannes Reinecke <hare@suse.de> Cc: Johannes Thumshirn <jthumshirn@suse.de> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'include/scsi')
-rw-r--r--include/scsi/scsi_device.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index 0979a5f3b69a..f054f3f43c75 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -111,7 +111,7 @@ struct scsi_device {
unsigned sector_size; /* size in bytes */
void *hostdata; /* available to low-level driver */
- char type;
+ unsigned char type;
char scsi_level;
char inq_periph_qual; /* PQ from INQUIRY data */
struct mutex inquiry_mutex;