summaryrefslogtreecommitdiffstats
path: root/include/uapi/linux/ethtool.h
diff options
context:
space:
mode:
authorFlorian Fainelli2013-05-23 03:11:11 +0200
committerDavid S. Miller2013-05-28 07:42:50 +0200
commit7ec872114251b618adf5a2688de0ca00de63635d (patch)
treeec96fdf9f4b8d810d5d5895afd255ab7cc0072dd /include/uapi/linux/ethtool.h
parentnet: wan: remove unnecessary platform_set_drvdata() (diff)
downloadkernel-qcow2-linux-7ec872114251b618adf5a2688de0ca00de63635d.tar.gz
kernel-qcow2-linux-7ec872114251b618adf5a2688de0ca00de63635d.tar.xz
kernel-qcow2-linux-7ec872114251b618adf5a2688de0ca00de63635d.zip
net: ethtool: disambiguate XCVR_* meaning
Add a comment which explains the real meaning of XCVR_INTERNAL (PHY and Ethernet MAC in the same package/die) and XCVR_EXTERNAL (PHY and Ethernet MAC in a different package/die). Most if not all of the drivers setting their transceiver type already do it the way the comment describes it. Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Reviewed-by: Ben Hutchings <bhutchings@solarflare.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/uapi/linux/ethtool.h')
-rw-r--r--include/uapi/linux/ethtool.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
index 0c9b44871df0..38dbafaa5341 100644
--- a/include/uapi/linux/ethtool.h
+++ b/include/uapi/linux/ethtool.h
@@ -993,8 +993,8 @@ enum ethtool_sfeatures_retval_bits {
#define PORT_OTHER 0xff
/* Which transceiver to use. */
-#define XCVR_INTERNAL 0x00
-#define XCVR_EXTERNAL 0x01
+#define XCVR_INTERNAL 0x00 /* PHY and MAC are in the same package */
+#define XCVR_EXTERNAL 0x01 /* PHY and MAC are in different packages */
#define XCVR_DUMMY1 0x02
#define XCVR_DUMMY2 0x03
#define XCVR_DUMMY3 0x04