diff options
| author | Jia-Ju Bai | 2018-04-11 03:15:31 +0200 |
|---|---|---|
| committer | Boris Ostrovsky | 2018-04-16 16:20:45 +0200 |
| commit | de3d01fd8549ec0444fc917aab711b3f884930c5 (patch) | |
| tree | 6a2e461e221e7cddc8f21923ce9deb8037b23d36 /include/xen | |
| parent | xen: xen-pciback: Replace GFP_ATOMIC with GFP_KERNEL in xen_pcibk_config_quir... (diff) | |
| download | kernel-qcow2-linux-de3d01fd8549ec0444fc917aab711b3f884930c5.tar.gz kernel-qcow2-linux-de3d01fd8549ec0444fc917aab711b3f884930c5.tar.xz kernel-qcow2-linux-de3d01fd8549ec0444fc917aab711b3f884930c5.zip | |
xen: xen-pciback: Replace GFP_ATOMIC with GFP_KERNEL in pcistub_reg_add
pcistub_reg_add() is never called in atomic context.
pcistub_reg_add() is only called by pcistub_quirk_add, which is
only set in DRIVER_ATTR().
Despite never getting called from atomic context,
pcistub_reg_add() calls kzalloc() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.
This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Diffstat (limited to 'include/xen')
0 files changed, 0 insertions, 0 deletions