diff options
| author | Oleg Nesterov | 2008-02-06 10:36:13 +0100 |
|---|---|---|
| committer | Linus Torvalds | 2008-02-06 19:41:00 +0100 |
| commit | d9ae90ac4bdce769ddb27c2e24c3351a30c3daf8 (patch) | |
| tree | 220f88576b5c83369892ce13cb180bab6cccba7a /kernel/signal.c | |
| parent | taskstats scaled time cleanup (diff) | |
| download | kernel-qcow2-linux-d9ae90ac4bdce769ddb27c2e24c3351a30c3daf8.tar.gz kernel-qcow2-linux-d9ae90ac4bdce769ddb27c2e24c3351a30c3daf8.tar.xz kernel-qcow2-linux-d9ae90ac4bdce769ddb27c2e24c3351a30c3daf8.zip | |
use __set_task_state() for TRACED/STOPPED tasks
1. It is much easier to grep for ->state change if __set_task_state() is used
instead of the direct assignment.
2. ptrace_stop() and handle_group_stop() use set_task_state() which adds the
unneeded mb() (btw even if we use mb() it is still possible that do_wait()
sees the new ->state but not ->exit_code, but this is ok).
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel/signal.c')
| -rw-r--r-- | kernel/signal.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/signal.c b/kernel/signal.c index 6a5f97cd337a..e46971560fcb 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -1601,7 +1601,7 @@ static void ptrace_stop(int exit_code, int nostop_code, siginfo_t *info) current->exit_code = exit_code; /* Let the debugger run. */ - set_current_state(TASK_TRACED); + __set_current_state(TASK_TRACED); spin_unlock_irq(¤t->sighand->siglock); try_to_freeze(); read_lock(&tasklist_lock); |