diff options
| author | Lai Jiangshan | 2009-07-15 10:27:30 +0200 |
|---|---|---|
| committer | Frederic Weisbecker | 2009-07-17 00:46:47 +0200 |
| commit | da706d8bc833e7153622435560422e653bdb2e94 (patch) | |
| tree | 0da824f6db67ce361976ef3b4d5a7212ea92619b /kernel/trace/ring_buffer.c | |
| parent | Merge branch 'tip/tracing/ring-buffer-3' of git://git.kernel.org/pub/scm/linu... (diff) | |
| download | kernel-qcow2-linux-da706d8bc833e7153622435560422e653bdb2e94.tar.gz kernel-qcow2-linux-da706d8bc833e7153622435560422e653bdb2e94.tar.xz kernel-qcow2-linux-da706d8bc833e7153622435560422e653bdb2e94.zip | |
ring_buffer: Fix warning while ignoring cmpxchg return value
kernel/trace/ring_buffer.c: In function 'rb_tail_page_update':
kernel/trace/ring_buffer.c:849: warning: value computed is not used
kernel/trace/ring_buffer.c:850: warning: value computed is not used
Add "(void)"s to fix this warning, because we don't need here to handle
the fail case of cmpxchg, it's fine if an interrupt already did the
job.
Changed from V1:
Add a comment(which is written by Steven) for it.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Diffstat (limited to 'kernel/trace/ring_buffer.c')
| -rw-r--r-- | kernel/trace/ring_buffer.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c index e648ba4f70e0..51633d74a21e 100644 --- a/kernel/trace/ring_buffer.c +++ b/kernel/trace/ring_buffer.c @@ -845,9 +845,14 @@ static int rb_tail_page_update(struct ring_buffer_per_cpu *cpu_buffer, * This will only succeed if an interrupt did * not come in and change it. In which case, we * do not want to modify it. + * + * We add (void) to let the compiler know that we do not care + * about the return value of these functions. We use the + * cmpxchg to only update if an interrupt did not already + * do it for us. If the cmpxchg fails, we don't care. */ - local_cmpxchg(&next_page->write, old_write, val); - local_cmpxchg(&next_page->entries, old_entries, eval); + (void)local_cmpxchg(&next_page->write, old_write, val); + (void)local_cmpxchg(&next_page->entries, old_entries, eval); /* * No need to worry about races with clearing out the commit. |