summaryrefslogtreecommitdiffstats
path: root/kernel/trace/trace_events_hist.c
diff options
context:
space:
mode:
authorSteven Rostedt (VMware)2018-12-20 19:20:07 +0100
committerSteven Rostedt (VMware)2018-12-23 04:51:54 +0100
commitb6b2735514bcd70ad1556a33892a636b20ece671 (patch)
treea51e1477fef62ca3223c272306ab4162ae23cb05 /kernel/trace/trace_events_hist.c
parenttracing: Use str_has_prefix() helper for histogram code (diff)
downloadkernel-qcow2-linux-b6b2735514bcd70ad1556a33892a636b20ece671.tar.gz
kernel-qcow2-linux-b6b2735514bcd70ad1556a33892a636b20ece671.tar.xz
kernel-qcow2-linux-b6b2735514bcd70ad1556a33892a636b20ece671.zip
tracing: Use str_has_prefix() instead of using fixed sizes
There are several instances of strncmp(str, "const", 123), where 123 is the strlen of the const string to check if "const" is the prefix of str. But this can be error prone. Use str_has_prefix() instead. Acked-by: Namhyung Kim <namhyung@kernel.org> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Diffstat (limited to 'kernel/trace/trace_events_hist.c')
-rw-r--r--kernel/trace/trace_events_hist.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
index 9d590138f870..0d878dcd1e4b 100644
--- a/kernel/trace/trace_events_hist.c
+++ b/kernel/trace/trace_events_hist.c
@@ -518,7 +518,7 @@ static int synth_event_define_fields(struct trace_event_call *call)
static bool synth_field_signed(char *type)
{
- if (strncmp(type, "u", 1) == 0)
+ if (str_has_prefix(type, "u"))
return false;
return true;