diff options
| author | Masami Hiramatsu | 2019-05-07 15:55:41 +0200 |
|---|---|---|
| committer | Steven Rostedt (VMware) | 2019-05-08 18:15:11 +0200 |
| commit | 4dd537aca25dd2e0e8aca8b8923930cbe6240003 (patch) | |
| tree | 4237d1d2cd0c827fd2d3edd8040b5fd6a9337375 /kernel/trace/trace_probe.h | |
| parent | ftrace/x86_64: Emulate call function while updating in breakpoint handler (diff) | |
| download | kernel-qcow2-linux-4dd537aca25dd2e0e8aca8b8923930cbe6240003.tar.gz kernel-qcow2-linux-4dd537aca25dd2e0e8aca8b8923930cbe6240003.tar.xz kernel-qcow2-linux-4dd537aca25dd2e0e8aca8b8923930cbe6240003.zip | |
tracing: uprobes: Re-enable $comm support for uprobe events
Since commit 533059281ee5 ("tracing: probeevent: Introduce new
argument fetching code") dropped the $comm support from uprobe
events, this re-enables it.
For $comm support, uses strlcpy() instead of strncpy_from_user()
to copy current task's comm. Because it is in the kernel space,
strncpy_from_user() always fails to copy the comm.
This also uses strlen() instead of strnlen_user() to measure the
length of the comm.
Note that this uses -ECOMM as a token value to fetch the comm
string. If the user-space pointer points -ECOMM, it will be
translated to task->comm.
Link: http://lkml.kernel.org/r/155723734162.9149.4042756162201097965.stgit@devnote2
Fixes: 533059281ee5 ("tracing: probeevent: Introduce new argument fetching code")
Reported-by: Andreas Ziegler <andreas.ziegler@fau.de>
Acked-by: Andreas Ziegler <andreas.ziegler@fau.de>
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Diffstat (limited to 'kernel/trace/trace_probe.h')
| -rw-r--r-- | kernel/trace/trace_probe.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/kernel/trace/trace_probe.h b/kernel/trace/trace_probe.h index b7737666c1a8..f9a8c632188b 100644 --- a/kernel/trace/trace_probe.h +++ b/kernel/trace/trace_probe.h @@ -124,6 +124,7 @@ struct fetch_insn { /* fetch + deref*N + store + mod + end <= 16, this allows N=12, enough */ #define FETCH_INSN_MAX 16 +#define FETCH_TOKEN_COMM (-ECOMM) /* Fetch type information table */ struct fetch_type { |