diff options
| author | Li Zefan | 2010-01-14 03:54:40 +0100 |
|---|---|---|
| committer | Steven Rostedt | 2010-01-15 04:38:14 +0100 |
| commit | d1303dd1d6b220cab375f24fa91a5640e54e169e (patch) | |
| tree | 6b37f4fe7ef331e18c35919ae2fab0ce9da5e6b9 /kernel/trace | |
| parent | tracing/filters: Fix MATCH_FULL filter matching for PTR_STRING (diff) | |
| download | kernel-qcow2-linux-d1303dd1d6b220cab375f24fa91a5640e54e169e.tar.gz kernel-qcow2-linux-d1303dd1d6b220cab375f24fa91a5640e54e169e.tar.xz kernel-qcow2-linux-d1303dd1d6b220cab375f24fa91a5640e54e169e.zip | |
tracing/filters: Add comment for match callbacks
We should be clear on 2 things:
- the length parameter of a match callback includes
tailing '\0'.
- the string to be searched might not be NULL-terminated.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
LKML-Reference: <4B4E8770.7000608@cn.fujitsu.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'kernel/trace')
| -rw-r--r-- | kernel/trace/trace_events_filter.c | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c index 60c2a4efad4a..e42af9aad69f 100644 --- a/kernel/trace/trace_events_filter.c +++ b/kernel/trace/trace_events_filter.c @@ -252,7 +252,18 @@ static int filter_pred_none(struct filter_pred *pred, void *event, return 0; } -/* Basic regex callbacks */ +/* + * regex_match_foo - Basic regex callbacks + * + * @str: the string to be searched + * @r: the regex structure containing the pattern string + * @len: the length of the string to be searched (including '\0') + * + * Note: + * - @str might not be NULL-terminated if it's of type DYN_STRING + * or STATIC_STRING + */ + static int regex_match_full(char *str, struct regex *r, int len) { if (strncmp(str, r->pattern, len) == 0) |