diff options
author | Jaewon Kim | 2015-09-09 00:02:21 +0200 |
---|---|---|
committer | Linus Torvalds | 2015-09-09 00:35:28 +0200 |
commit | c54839a722a02818677bcabe57e957f0ce4f841d (patch) | |
tree | fccaef494e4c693e8972da14354c623366a3fbec /mm/dmapool.c | |
parent | mm: vmscan: never isolate more pages than necessary (diff) | |
download | kernel-qcow2-linux-c54839a722a02818677bcabe57e957f0ce4f841d.tar.gz kernel-qcow2-linux-c54839a722a02818677bcabe57e957f0ce4f841d.tar.xz kernel-qcow2-linux-c54839a722a02818677bcabe57e957f0ce4f841d.zip |
vmscan: fix increasing nr_isolated incurred by putback unevictable pages
reclaim_clean_pages_from_list() assumes that shrink_page_list() returns
number of pages removed from the candidate list. But shrink_page_list()
puts back mlocked pages without passing it to caller and without
counting as nr_reclaimed. This increases nr_isolated.
To fix this, this patch changes shrink_page_list() to pass unevictable
pages back to caller. Caller will take care those pages.
Minchan said:
It fixes two issues.
1. With unevictable page, cma_alloc will be successful.
Exactly speaking, cma_alloc of current kernel will fail due to
unevictable pages.
2. fix leaking of NR_ISOLATED counter of vmstat
With it, too_many_isolated works. Otherwise, it could make hang until
the process get SIGKILL.
Signed-off-by: Jaewon Kim <jaewon31.kim@samsung.com>
Acked-by: Minchan Kim <minchan@kernel.org>
Cc: Mel Gorman <mgorman@techsingularity.net>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/dmapool.c')
0 files changed, 0 insertions, 0 deletions