summaryrefslogtreecommitdiffstats
path: root/mm/hmm.c
diff options
context:
space:
mode:
authorJason Gunthorpe2019-05-23 16:23:30 +0200
committerJason Gunthorpe2019-06-18 17:13:06 +0200
commit8a1a0cd0b770a0f40a49db923479879fa7135aae (patch)
tree6f77990d5495984f3d0106d22008cb63439c7c1f /mm/hmm.c
parentmm/hmm: Hold on to the mmget for the lifetime of the range (diff)
downloadkernel-qcow2-linux-8a1a0cd0b770a0f40a49db923479879fa7135aae.tar.gz
kernel-qcow2-linux-8a1a0cd0b770a0f40a49db923479879fa7135aae.tar.xz
kernel-qcow2-linux-8a1a0cd0b770a0f40a49db923479879fa7135aae.zip
mm/hmm: Use lockdep instead of comments
So we can check locking at runtime. Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> Reviewed-by: Jérôme Glisse <jglisse@redhat.com> Reviewed-by: John Hubbard <jhubbard@nvidia.com> Reviewed-by: Ralph Campbell <rcampbell@nvidia.com> Acked-by: Souptick Joarder <jrdr.linux@gmail.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Tested-by: Philip Yang <Philip.Yang@amd.com>
Diffstat (limited to 'mm/hmm.c')
-rw-r--r--mm/hmm.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/mm/hmm.c b/mm/hmm.c
index 1eddda45cefa..6f5dc6d568fe 100644
--- a/mm/hmm.c
+++ b/mm/hmm.c
@@ -246,11 +246,11 @@ static const struct mmu_notifier_ops hmm_mmu_notifier_ops = {
*
* To start mirroring a process address space, the device driver must register
* an HMM mirror struct.
- *
- * THE mm->mmap_sem MUST BE HELD IN WRITE MODE !
*/
int hmm_mirror_register(struct hmm_mirror *mirror, struct mm_struct *mm)
{
+ lockdep_assert_held_exclusive(&mm->mmap_sem);
+
/* Sanity check */
if (!mm || !mirror || !mirror->ops)
return -EINVAL;