diff options
| author | Michal Hocko | 2018-10-27 00:06:49 +0200 |
|---|---|---|
| committer | Linus Torvalds | 2018-10-27 01:26:33 +0200 |
| commit | 2c029a1ea3aac296cd5b47584a579defcc4b4aa0 (patch) | |
| tree | 1cd03467941fd59beaf3bb8e9a37b7b6bc302cb6 /mm/swap.c | |
| parent | mm/memcontrol.c: fix memory.stat item ordering (diff) | |
| download | kernel-qcow2-linux-2c029a1ea3aac296cd5b47584a579defcc4b4aa0.tar.gz kernel-qcow2-linux-2c029a1ea3aac296cd5b47584a579defcc4b4aa0.tar.xz kernel-qcow2-linux-2c029a1ea3aac296cd5b47584a579defcc4b4aa0.zip | |
mm, page_alloc: drop should_suppress_show_mem
should_suppress_show_mem() was introduced to reduce the overhead of
show_mem on large NUMA systems. Things have changed since then though.
Namely c78e93630d15 ("mm: do not walk all of system memory during
show_mem") has reduced the overhead considerably.
Moreover warn_alloc_show_mem clears SHOW_MEM_FILTER_NODES when called from
the IRQ context already so we are not printing per node stats.
Remove should_suppress_show_mem because we are losing potentially
interesting information about allocation failures. We have seen a bug
report where system gets unresponsive under memory pressure and there is
only
kernel: [2032243.696888] qlge 0000:8b:00.1 ql1: Could not get a page chunk, i=8, clean_idx =200 .
kernel: [2032243.710725] swapper/7: page allocation failure: order:1, mode:0x1084120(GFP_ATOMIC|__GFP_COLD|__GFP_COMP)
without an additional information for debugging. It would be great to see
the state of the page allocator at the moment.
Link: http://lkml.kernel.org/r/20180907114334.7088-1-mhocko@kernel.org
Signed-off-by: Michal Hocko <mhocko@suse.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Cc: David Rientjes <rientjes@google.com>
Cc: Mel Gorman <mgorman@techsingularity.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/swap.c')
0 files changed, 0 insertions, 0 deletions