summaryrefslogtreecommitdiffstats
path: root/net/batman-adv/distributed-arp-table.c
diff options
context:
space:
mode:
authorSven Eckelmann2016-01-16 10:29:56 +0100
committerAntonio Quartulli2016-02-10 16:24:06 +0100
commit7c12439115da77389733d9bf313f64eedaec3b73 (patch)
tree795d74a4209cd98798f0e4068ebe67a20e22655e /net/batman-adv/distributed-arp-table.c
parentbatman-adv: Convert batadv_orig_node_vlan to kref (diff)
downloadkernel-qcow2-linux-7c12439115da77389733d9bf313f64eedaec3b73.tar.gz
kernel-qcow2-linux-7c12439115da77389733d9bf313f64eedaec3b73.tar.xz
kernel-qcow2-linux-7c12439115da77389733d9bf313f64eedaec3b73.zip
batman-adv: Convert batadv_orig_node to kref
batman-adv uses a self-written reference implementation which is just based on atomic_t. This is less obvious when reading the code than kref and therefore increases the change that the reference counting will be missed. Signed-off-by: Sven Eckelmann <sven@narfation.org> Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch> Signed-off-by: Antonio Quartulli <a@unstable.cc>
Diffstat (limited to 'net/batman-adv/distributed-arp-table.c')
-rw-r--r--net/batman-adv/distributed-arp-table.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/batman-adv/distributed-arp-table.c b/net/batman-adv/distributed-arp-table.c
index 921e25255cab..e3261118130a 100644
--- a/net/batman-adv/distributed-arp-table.c
+++ b/net/batman-adv/distributed-arp-table.c
@@ -542,7 +542,7 @@ static void batadv_choose_next_candidate(struct batadv_priv *bat_priv,
max_orig_node))
continue;
- if (!atomic_inc_not_zero(&orig_node->refcount))
+ if (!kref_get_unless_zero(&orig_node->refcount))
continue;
max = tmp_max;