diff options
| author | Sven Eckelmann | 2016-07-15 17:39:21 +0200 |
|---|---|---|
| committer | Simon Wunderlich | 2016-08-09 07:54:46 +0200 |
| commit | 55db2d590298e8ffe6ee66134157aa710e45faa2 (patch) | |
| tree | e164cb4d3dea339f07eb8050f6699847b87d0eaa /net/batman-adv/gateway_client.c | |
| parent | batman-adv: Place kref_get for neigh_node near use (diff) | |
| download | kernel-qcow2-linux-55db2d590298e8ffe6ee66134157aa710e45faa2.tar.gz kernel-qcow2-linux-55db2d590298e8ffe6ee66134157aa710e45faa2.tar.xz kernel-qcow2-linux-55db2d590298e8ffe6ee66134157aa710e45faa2.zip | |
batman-adv: Place kref_get for orig_node near use
It is hard to understand why the refcnt is increased when it isn't done
near the actual place the new reference is used. So using kref_get right
before the place which requires the reference and in the same function
helps to avoid accidental problems caused by incorrect reference counting.
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Diffstat (limited to 'net/batman-adv/gateway_client.c')
| -rw-r--r-- | net/batman-adv/gateway_client.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/batman-adv/gateway_client.c b/net/batman-adv/gateway_client.c index c2928c2287b8..b889e1fdba4d 100644 --- a/net/batman-adv/gateway_client.c +++ b/net/batman-adv/gateway_client.c @@ -339,8 +339,8 @@ static void batadv_gw_node_add(struct batadv_priv *bat_priv, if (!gw_node) return; - kref_get(&orig_node->refcount); INIT_HLIST_NODE(&gw_node->list); + kref_get(&orig_node->refcount); gw_node->orig_node = orig_node; gw_node->bandwidth_down = ntohl(gateway->bandwidth_down); gw_node->bandwidth_up = ntohl(gateway->bandwidth_up); |