diff options
| author | Sven Eckelmann | 2016-07-15 17:39:17 +0200 |
|---|---|---|
| committer | Simon Wunderlich | 2016-08-09 07:54:44 +0200 |
| commit | f257b99becf5183c721a3e0e41ad9b9fbbddbd44 (patch) | |
| tree | 75d0ef941cf4cf01dd23c819faa078f6003ed45d /net/batman-adv/originator.c | |
| parent | batman-adv: Place kref_get for orig_node_vlan near use (diff) | |
| download | kernel-qcow2-linux-f257b99becf5183c721a3e0e41ad9b9fbbddbd44.tar.gz kernel-qcow2-linux-f257b99becf5183c721a3e0e41ad9b9fbbddbd44.tar.xz kernel-qcow2-linux-f257b99becf5183c721a3e0e41ad9b9fbbddbd44.zip | |
batman-adv: Place kref_get for orig_ifinfo near use
It is hard to understand why the refcnt is increased when it isn't done
near the actual place the new reference is used. So using kref_get right
before the place which requires the reference and in the same function
helps to avoid accidental problems caused by incorrect reference counting.
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Diffstat (limited to 'net/batman-adv/originator.c')
| -rw-r--r-- | net/batman-adv/originator.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/batman-adv/originator.c b/net/batman-adv/originator.c index 5108af11a6e9..88289645f3c9 100644 --- a/net/batman-adv/originator.c +++ b/net/batman-adv/originator.c @@ -386,6 +386,7 @@ batadv_orig_ifinfo_new(struct batadv_orig_node *orig_node, orig_ifinfo->if_outgoing = if_outgoing; INIT_HLIST_NODE(&orig_ifinfo->list); kref_init(&orig_ifinfo->refcount); + kref_get(&orig_ifinfo->refcount); hlist_add_head_rcu(&orig_ifinfo->list, &orig_node->ifinfo_list); |