diff options
| author | David Herrmann | 2013-04-06 20:28:40 +0200 |
|---|---|---|
| committer | Gustavo Padovan | 2013-04-17 07:46:51 +0200 |
| commit | dcc07647f17836ecf9f4c54e44624b048ab8c297 (patch) | |
| tree | 7774d5c1dce1f2fcefd90cf2876c02199b8c9933 /net/bluetooth/hidp/hidp.h | |
| parent | Bluetooth: introduce hci_conn ref-counting (diff) | |
| download | kernel-qcow2-linux-dcc07647f17836ecf9f4c54e44624b048ab8c297.tar.gz kernel-qcow2-linux-dcc07647f17836ecf9f4c54e44624b048ab8c297.tar.xz kernel-qcow2-linux-dcc07647f17836ecf9f4c54e44624b048ab8c297.zip | |
Bluetooth: hidp: remove unused session->state field
This field is always BT_CONNECTED. Remove it and set it to BT_CONNECTED in
hidp_copy_session() unconditionally.
Also note that this field is totally bogus. Userspace can query an
hidp-session for its state. However, whenever user-space queries us, this
field should be BT_CONNECTED. If it wasn't BT_CONNECTED, then we would be
currently cleaning up the session and the session itself would exit in the
next few milliseconds. Hence, there is no reason to let user-space know
that the session will exit now if they cannot make _any_ use of that.
Thus, remove the field and let user-space think that a session is always
BT_CONNECTED as long as they can query it.
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Diffstat (limited to 'net/bluetooth/hidp/hidp.h')
| -rw-r--r-- | net/bluetooth/hidp/hidp.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/bluetooth/hidp/hidp.h b/net/bluetooth/hidp/hidp.h index af1bcc823f26..57a6191674fd 100644 --- a/net/bluetooth/hidp/hidp.h +++ b/net/bluetooth/hidp/hidp.h @@ -135,7 +135,6 @@ struct hidp_session { bdaddr_t bdaddr; - unsigned long state; unsigned long flags; unsigned long idle_to; |