diff options
| author | Ville Tervo | 2011-02-22 20:10:53 +0100 |
|---|---|---|
| committer | Gustavo F. Padovan | 2011-02-27 21:11:29 +0100 |
| commit | 30e7627219f985cd17a1ac24e0163ebcfb1277bf (patch) | |
| tree | f4c6688dff4b74d42327ca43b4660b9848c40b01 /net/bluetooth/l2cap_core.c | |
| parent | Bluetooth: Validate data size before accessing mgmt commands (diff) | |
| download | kernel-qcow2-linux-30e7627219f985cd17a1ac24e0163ebcfb1277bf.tar.gz kernel-qcow2-linux-30e7627219f985cd17a1ac24e0163ebcfb1277bf.tar.xz kernel-qcow2-linux-30e7627219f985cd17a1ac24e0163ebcfb1277bf.zip | |
Bluetooth: Use ERR_PTR as return error from hci_connect
Use ERR_PTR mechanism to return error from hci_connect.
Signed-off-by: Ville Tervo <ville.tervo@nokia.com>
Signed-off-by: Anderson Briglia <anderson.briglia@openbossa.org>
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
Diffstat (limited to 'net/bluetooth/l2cap_core.c')
| -rw-r--r-- | net/bluetooth/l2cap_core.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c index 1db6c9081aa7..c9f9cecca527 100644 --- a/net/bluetooth/l2cap_core.c +++ b/net/bluetooth/l2cap_core.c @@ -852,8 +852,6 @@ int l2cap_do_connect(struct sock *sk) hci_dev_lock_bh(hdev); - err = -ENOMEM; - auth_type = l2cap_get_auth_type(sk); if (l2cap_pi(sk)->dcid == L2CAP_CID_LE_DATA) @@ -863,17 +861,18 @@ int l2cap_do_connect(struct sock *sk) hcon = hci_connect(hdev, ACL_LINK, dst, l2cap_pi(sk)->sec_level, auth_type); - if (!hcon) + if (IS_ERR(hcon)) { + err = PTR_ERR(hcon); goto done; + } conn = l2cap_conn_add(hcon, 0); if (!conn) { hci_conn_put(hcon); + err = -ENOMEM; goto done; } - err = 0; - /* Update source addr of the socket */ bacpy(src, conn->src); @@ -892,6 +891,8 @@ int l2cap_do_connect(struct sock *sk) l2cap_do_start(sk); } + err = 0; + done: hci_dev_unlock_bh(hdev); hci_dev_put(hdev); |