summaryrefslogtreecommitdiffstats
path: root/net/bluetooth
diff options
context:
space:
mode:
authorJohan Hedberg2013-01-20 13:27:16 +0100
committerGustavo Padovan2013-01-23 04:56:51 +0100
commit3f706b7205456c90cdc91e21eab36e2fcf4a8bce (patch)
tree291736a32da4624e99c1c651a7e5a456ed98ef9a /net/bluetooth
parentBluetooth: Fix checking for proper key->master value in Load LTKs (diff)
downloadkernel-qcow2-linux-3f706b7205456c90cdc91e21eab36e2fcf4a8bce.tar.gz
kernel-qcow2-linux-3f706b7205456c90cdc91e21eab36e2fcf4a8bce.tar.xz
kernel-qcow2-linux-3f706b7205456c90cdc91e21eab36e2fcf4a8bce.zip
Bluetooth: Refactor valid LTK data testing into its own function
This patch refactors valid LTK data testing into its own function. This will help keep the code readable since there are several tests still missing that need to be done on the LTK data. Signed-off-by: Johan Hedberg <johan.hedberg@intel.com> Acked-by: Marcel Holtmann <marcel@holtmann.org> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Diffstat (limited to 'net/bluetooth')
-rw-r--r--net/bluetooth/mgmt.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index c7ec47ce94e5..cd758994b02f 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -2701,6 +2701,13 @@ done:
return err;
}
+static bool ltk_is_valid(struct mgmt_ltk_info *key)
+{
+ if (key->master != 0x00 && key->master != 0x01)
+ return false;
+ return true;
+}
+
static int load_long_term_keys(struct sock *sk, struct hci_dev *hdev,
void *cp_data, u16 len)
{
@@ -2724,7 +2731,7 @@ static int load_long_term_keys(struct sock *sk, struct hci_dev *hdev,
for (i = 0; i < key_count; i++) {
struct mgmt_ltk_info *key = &cp->keys[i];
- if (key->master != 0x00 && key->master != 0x01)
+ if (!ltk_is_valid(key))
return cmd_status(sk, hdev->id,
MGMT_OP_LOAD_LONG_TERM_KEYS,
MGMT_STATUS_INVALID_PARAMS);