diff options
| author | Eric Dumazet | 2014-06-06 15:44:03 +0200 |
|---|---|---|
| committer | David S. Miller | 2014-06-08 23:15:14 +0200 |
| commit | 87757a917b0b3c0787e0563c679762152be81312 (patch) | |
| tree | ffc8bfa37fc3db09ac90bff273fbf13085e8d558 /net/core/rtnetlink.c | |
| parent | net: qmi_wwan: add Olivetti Olicard modems (diff) | |
| download | kernel-qcow2-linux-87757a917b0b3c0787e0563c679762152be81312.tar.gz kernel-qcow2-linux-87757a917b0b3c0787e0563c679762152be81312.tar.xz kernel-qcow2-linux-87757a917b0b3c0787e0563c679762152be81312.zip | |
net: force a list_del() in unregister_netdevice_many()
unregister_netdevice_many() API is error prone and we had too
many bugs because of dangling LIST_HEAD on stacks.
See commit f87e6f47933e3e ("net: dont leave active on stack LIST_HEAD")
In fact, instead of making sure no caller leaves an active list_head,
just force a list_del() in the callee. No one seems to need to access
the list after unregister_netdevice_many()
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/rtnetlink.c')
| -rw-r--r-- | net/core/rtnetlink.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index f4e9037f9a0c..fbdb1556b0db 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -1744,7 +1744,6 @@ static int rtnl_dellink(struct sk_buff *skb, struct nlmsghdr *nlh) ops->dellink(dev, &list_kill); unregister_netdevice_many(&list_kill); - list_del(&list_kill); return 0; } |