diff options
| author | Gerrit Renker | 2006-11-10 15:32:01 +0100 |
|---|---|---|
| committer | David S. Miller | 2006-12-03 06:21:58 +0100 |
| commit | 8a73cd09d96aa01743316657fc4e6864fe79b703 (patch) | |
| tree | fa22ed8ac78c5c76cc8ee3afd8bf72607290d42d /net/dccp/dccp.h | |
| parent | [DCCP] timewait: Remove leftover extern declarations (diff) | |
| download | kernel-qcow2-linux-8a73cd09d96aa01743316657fc4e6864fe79b703.tar.gz kernel-qcow2-linux-8a73cd09d96aa01743316657fc4e6864fe79b703.tar.xz kernel-qcow2-linux-8a73cd09d96aa01743316657fc4e6864fe79b703.zip | |
[DCCP]: calling dccp_v{4,6}_reqsk_send_ack is a BUG
This patch removes two functions, the send_ack functions of request_sock,
which are not called/used by the DCCP code. It is correct that these
functions are not called, below is a justification why calling these
functions (on a passive socket in the LISTEN/RESPOND state) would mean
a DCCP protocol violation.
A) Background: using request_sock in TCP:
Diffstat (limited to 'net/dccp/dccp.h')
| -rw-r--r-- | net/dccp/dccp.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/dccp/dccp.h b/net/dccp/dccp.h index 8964b188aba3..3d4b4a908d11 100644 --- a/net/dccp/dccp.h +++ b/net/dccp/dccp.h @@ -131,6 +131,8 @@ extern int dccp_retransmit_skb(struct sock *sk, struct sk_buff *skb); extern void dccp_send_ack(struct sock *sk); extern void dccp_send_delayed_ack(struct sock *sk); +extern void dccp_reqsk_send_ack(struct sk_buff *sk, struct request_sock *rsk); + extern void dccp_send_sync(struct sock *sk, const u64 seq, const enum dccp_pkt_type pkt_type); |