diff options
| author | Vasiliy Kulikov | 2011-03-17 02:40:10 +0100 |
|---|---|---|
| committer | David S. Miller | 2011-03-18 23:12:15 +0100 |
| commit | 67c5c6cb8129c595f21e88254a3fc6b3b841ae8e (patch) | |
| tree | 76b219ead6898d683e477e2fa2579145e792bd0a /net/econet/af_econet.c | |
| parent | gianfar: Fall back to software tcp/udp checksum on older controllers (diff) | |
| download | kernel-qcow2-linux-67c5c6cb8129c595f21e88254a3fc6b3b841ae8e.tar.gz kernel-qcow2-linux-67c5c6cb8129c595f21e88254a3fc6b3b841ae8e.tar.xz kernel-qcow2-linux-67c5c6cb8129c595f21e88254a3fc6b3b841ae8e.zip | |
econet: 4 byte infoleak to the network
struct aunhdr has 4 padding bytes between 'pad' and 'handle' fields on
x86_64. These bytes are not initialized in the variable 'ah' before
sending 'ah' to the network. This leads to 4 bytes kernel stack
infoleak.
This bug was introduced before the git epoch.
Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Acked-by: Phil Blundell <philb@gnu.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/econet/af_econet.c')
| -rw-r--r-- | net/econet/af_econet.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/econet/af_econet.c b/net/econet/af_econet.c index 0c2826337919..116d3fd3d669 100644 --- a/net/econet/af_econet.c +++ b/net/econet/af_econet.c @@ -435,10 +435,10 @@ static int econet_sendmsg(struct kiocb *iocb, struct socket *sock, udpdest.sin_addr.s_addr = htonl(network | addr.station); } + memset(&ah, 0, sizeof(ah)); ah.port = port; ah.cb = cb & 0x7f; ah.code = 2; /* magic */ - ah.pad = 0; /* tack our header on the front of the iovec */ size = sizeof(struct aunhdr); |