diff options
| author | David Ahern | 2017-05-28 00:19:26 +0200 |
|---|---|---|
| committer | David S. Miller | 2017-05-30 17:55:31 +0200 |
| commit | 78055998954b7a3e6c31eb24d1d26f0b63a7ec0d (patch) | |
| tree | ad1f4fd34da0b9faee5219a3490cbf729228ba96 /net/ipv4/fib_frontend.c | |
| parent | net: ipv4: refactor key and length checks (diff) | |
| download | kernel-qcow2-linux-78055998954b7a3e6c31eb24d1d26f0b63a7ec0d.tar.gz kernel-qcow2-linux-78055998954b7a3e6c31eb24d1d26f0b63a7ec0d.tar.xz kernel-qcow2-linux-78055998954b7a3e6c31eb24d1d26f0b63a7ec0d.zip | |
net: ipv4: Add extack message for invalid prefix or length
Add extack error message for invalid prefix length and invalid prefix.
Example of the latter is a route spec containing 172.16.100.1/24, where
the /24 mask means the lower 8-bits should be 0. Amazing how easy that
one is to overlook when an EINVAL is returned.
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/fib_frontend.c')
| -rw-r--r-- | net/ipv4/fib_frontend.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c index 14d2f7bd7c76..715b7967d8ea 100644 --- a/net/ipv4/fib_frontend.c +++ b/net/ipv4/fib_frontend.c @@ -588,7 +588,8 @@ int ip_rt_ioctl(struct net *net, unsigned int cmd, void __user *arg) if (cmd == SIOCDELRT) { tb = fib_get_table(net, cfg.fc_table); if (tb) - err = fib_table_delete(net, tb, &cfg); + err = fib_table_delete(net, tb, &cfg, + NULL); else err = -ESRCH; } else { @@ -732,7 +733,7 @@ static int inet_rtm_delroute(struct sk_buff *skb, struct nlmsghdr *nlh, goto errout; } - err = fib_table_delete(net, tb, &cfg); + err = fib_table_delete(net, tb, &cfg, extack); errout: return err; } @@ -851,7 +852,7 @@ static void fib_magic(int cmd, int type, __be32 dst, int dst_len, struct in_ifad if (cmd == RTM_NEWROUTE) fib_table_insert(net, tb, &cfg, NULL); else - fib_table_delete(net, tb, &cfg); + fib_table_delete(net, tb, &cfg, NULL); } void fib_add_ifaddr(struct in_ifaddr *ifa) |