summaryrefslogtreecommitdiffstats
path: root/net/ipv4/netfilter/nf_nat_proto_icmp.c
diff options
context:
space:
mode:
authorChangli Gao2010-08-02 17:20:54 +0200
committerPatrick McHardy2010-08-02 17:20:54 +0200
commitf43dc98b3be36551143e3bbaf1bb3067835c24f4 (patch)
tree65d157024f399f49f8798ab9f905d66dc4f11a52 /net/ipv4/netfilter/nf_nat_proto_icmp.c
parentnetfilter: nf_nat: use local variable hdrlen (diff)
downloadkernel-qcow2-linux-f43dc98b3be36551143e3bbaf1bb3067835c24f4.tar.gz
kernel-qcow2-linux-f43dc98b3be36551143e3bbaf1bb3067835c24f4.tar.xz
kernel-qcow2-linux-f43dc98b3be36551143e3bbaf1bb3067835c24f4.zip
netfilter: nf_nat: make unique_tuple return void
The only user of unique_tuple() get_unique_tuple() doesn't care about the return value of unique_tuple(), so make unique_tuple() return void (nothing). Signed-off-by: Changli Gao <xiaosuo@gmail.com> Signed-off-by: Patrick McHardy <kaber@trash.net>
Diffstat (limited to 'net/ipv4/netfilter/nf_nat_proto_icmp.c')
-rw-r--r--net/ipv4/netfilter/nf_nat_proto_icmp.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/net/ipv4/netfilter/nf_nat_proto_icmp.c b/net/ipv4/netfilter/nf_nat_proto_icmp.c
index 19a8b0b07d8e..97003fe312e3 100644
--- a/net/ipv4/netfilter/nf_nat_proto_icmp.c
+++ b/net/ipv4/netfilter/nf_nat_proto_icmp.c
@@ -27,7 +27,7 @@ icmp_in_range(const struct nf_conntrack_tuple *tuple,
ntohs(tuple->src.u.icmp.id) <= ntohs(max->icmp.id);
}
-static bool
+static void
icmp_unique_tuple(struct nf_conntrack_tuple *tuple,
const struct nf_nat_range *range,
enum nf_nat_manip_type maniptype,
@@ -46,9 +46,9 @@ icmp_unique_tuple(struct nf_conntrack_tuple *tuple,
tuple->src.u.icmp.id = htons(ntohs(range->min.icmp.id) +
(id % range_size));
if (!nf_nat_used_tuple(tuple, ct))
- return true;
+ return;
}
- return false;
+ return;
}
static bool