diff options
| author | Patrick McHardy | 2007-12-18 06:47:14 +0100 |
|---|---|---|
| committer | David S. Miller | 2008-01-28 23:58:30 +0100 |
| commit | 30c08c41be75145b8850ea14b2d5ee4ee4b705d8 (patch) | |
| tree | c7d9e721823d74a9d0c166274ad0564a3de9f541 /net/ipv4/netfilter | |
| parent | [NETFILTER]: {ip,ip6,arp}_tables: consolidate iterator macros (diff) | |
| download | kernel-qcow2-linux-30c08c41be75145b8850ea14b2d5ee4ee4b705d8.tar.gz kernel-qcow2-linux-30c08c41be75145b8850ea14b2d5ee4ee4b705d8.tar.xz kernel-qcow2-linux-30c08c41be75145b8850ea14b2d5ee4ee4b705d8.zip | |
[NETFILTER]: ip_tables: account for struct ipt_entry/struct compat_ipt_entry size diff
Account for size differences when dumping entries or calculating the
entry positions. This doesn't actually make any difference for IPv4
since the structures have the same size, but its logically correct
and needed for IPv6.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/netfilter')
| -rw-r--r-- | net/ipv4/netfilter/ip_tables.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/net/ipv4/netfilter/ip_tables.c b/net/ipv4/netfilter/ip_tables.c index 4586af397ef4..cc896fe2fd92 100644 --- a/net/ipv4/netfilter/ip_tables.c +++ b/net/ipv4/netfilter/ip_tables.c @@ -1098,7 +1098,7 @@ static int compat_calc_entry(struct ipt_entry *e, unsigned int entry_offset; int off, i, ret; - off = 0; + off = sizeof(struct ipt_entry) - sizeof(struct compat_ipt_entry); entry_offset = (void *)e - base; IPT_MATCH_ITERATE(e, compat_calc_match, &off); t = ipt_get_target(e); @@ -1501,6 +1501,8 @@ compat_copy_entry_to_user(struct ipt_entry *e, void __user **dstptr, goto out; *dstptr += sizeof(struct compat_ipt_entry); + *size -= sizeof(struct ipt_entry) - sizeof(struct compat_ipt_entry); + ret = IPT_MATCH_ITERATE(e, xt_compat_match_to_user, dstptr, size); target_offset = e->target_offset - (origsize - *size); if (ret) @@ -1605,7 +1607,7 @@ check_compat_entry_size_and_hooks(struct ipt_entry *e, if (ret) return ret; - off = 0; + off = sizeof(struct ipt_entry) - sizeof(struct compat_ipt_entry); entry_offset = (void *)e - (void *)base; j = 0; ret = IPT_MATCH_ITERATE(e, compat_find_calc_match, name, &e->ip, @@ -1671,6 +1673,8 @@ compat_copy_entry_from_user(struct ipt_entry *e, void **dstptr, memcpy(de, e, sizeof(struct ipt_entry)); *dstptr += sizeof(struct compat_ipt_entry); + *size += sizeof(struct ipt_entry) - sizeof(struct compat_ipt_entry); + ret = IPT_MATCH_ITERATE(e, xt_compat_match_from_user, dstptr, size); if (ret) return ret; |