diff options
| author | Neal Cardwell | 2012-08-19 05:30:38 +0200 |
|---|---|---|
| committer | David S. Miller | 2012-08-20 12:03:33 +0200 |
| commit | fae6ef87faeb8853896920c68ee703d715799d28 (patch) | |
| tree | 67a31066d1ad0a6f2f997ee64dd4eb78b05b9a19 /net/ipv4/tcp_ipv4.c | |
| parent | net/core/dev.c: fix kernel-doc warning (diff) | |
| download | kernel-qcow2-linux-fae6ef87faeb8853896920c68ee703d715799d28.tar.gz kernel-qcow2-linux-fae6ef87faeb8853896920c68ee703d715799d28.tar.xz kernel-qcow2-linux-fae6ef87faeb8853896920c68ee703d715799d28.zip | |
net: tcp: move sk_rx_dst_set call after tcp_create_openreq_child()
This commit removes the sk_rx_dst_set calls from
tcp_create_openreq_child(), because at that point the icsk_af_ops
field of ipv6_mapped TCP sockets has not been set to its proper final
value.
Instead, to make sure we get the right sk_rx_dst_set variant
appropriate for the address family of the new connection, we have
tcp_v{4,6}_syn_recv_sock() directly call the appropriate function
shortly after the call to tcp_create_openreq_child() returns.
This also moves inet6_sk_rx_dst_set() to avoid a forward declaration
with the new approach.
Signed-off-by: Neal Cardwell <ncardwell@google.com>
Reported-by: Artem Savkov <artem.savkov@gmail.com>
Cc: Eric Dumazet <edumazet@google.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_ipv4.c')
| -rw-r--r-- | net/ipv4/tcp_ipv4.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index 767823764016..5bf2040b25b1 100644 --- a/net/ipv4/tcp_ipv4.c +++ b/net/ipv4/tcp_ipv4.c @@ -1462,6 +1462,7 @@ struct sock *tcp_v4_syn_recv_sock(struct sock *sk, struct sk_buff *skb, goto exit_nonewsk; newsk->sk_gso_type = SKB_GSO_TCPV4; + inet_sk_rx_dst_set(newsk, skb); newtp = tcp_sk(newsk); newinet = inet_sk(newsk); |